SLLS-345 fall back to window/showMessage for unsupported clients #551
Conversation
|
schrieveslaach
left a comment
schrieveslaach
left a comment
There was a problem hiding this comment.
@sophio-japharidze-sonarsource, thanks for looking into #548. Please, have a look at my remarks.
| @JsonNotification("doNotShowMissingRequirementsMessageAgain") | ||
| void doNotShowMissingRequirementsMessageAgain(); | ||
|
|
||
| enum MissingRequirementsNotificationDisplayOption { |
There was a problem hiding this comment.
#548 introduced ShowMissingRequirementsNotificationDeserializer to keep the protocol backward compatible (sonarlint/canShowMissingRequirementsNotification can then return boolean and the enum values).
This could be extremely helpful, because currently, I know that users of sonarlint.nvim are on different versions. For example, people on Mason did not receive a recent update because mason-org/mason-registry#11979 is blocked for some reason.
If you don't want to include the custom deserializer, then I suppose this is another major version bump, isn't it?
There was a problem hiding this comment.
I've updated the PR with the custom deserialiser. I've added tests for it, and tested manually that it works. Please also double-check on your side.
There was a problem hiding this comment.
Thank you for taking the time. I wanted to test it locally by building the version on this branch, but the compilation failed because some dependencies are not publicly available:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.163 s
[INFO] Finished at: 2025-11-06T08:23:02+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project sonarlint-language-server: Could not resolve dependencies for project org.sonarsource.sonarlint.ls:sonarlint-language-server:jar:4.5-SNAPSHOT
[ERROR] dependency: org.sonarsource.sonarlint.core:sonarlint-java-client-utils:jar:10.36.0.83608 (compile)
[ERROR] Could not find artifact org.sonarsource.sonarlint.core:sonarlint-java-client-utils:jar:10.36.0.83608 in central (https://repo.maven.apache.org/maven2)
[ERROR] dependency: org.sonarsource.sonarlint.core:sonarlint-rpc-protocol:jar:10.36.0.83608 (compile)
[ERROR] Could not find artifact org.sonarsource.sonarlint.core:sonarlint-rpc-protocol:jar:10.36.0.83608 in central (https://repo.maven.apache.org/maven2)
[ERROR] dependency: org.sonarsource.sonarlint.core:sonarlint-rpc-impl:jar:10.36.0.83608 (compile)
[ERROR] Could not find artifact org.sonarsource.sonarlint.core:sonarlint-rpc-impl:jar:10.36.0.83608 in central (https://repo.maven.apache.org/maven2)
[ERROR] dependency: org.sonarsource.sonarlint.core:sonarlint-rpc-java-client:jar:10.36.0.83608 (compile)
[ERROR] Could not find artifact org.sonarsource.sonarlint.core:sonarlint-rpc-java-client:jar:10.36.0.83608 in central (https://repo.maven.apache.org/maven2)
Is there a public Maven repo that I can add to my Maven settings and that hosts these versions?
There was a problem hiding this comment.
I found a workaround: I cherry-picked your commit onto the tagged release and then I could build it locally. Then, I could see the error in Neovim based, using this MR
There was a problem hiding this comment.
Great! Once my teammate approves the changes, I will merge the PR and close the other one. Thanks for the contribution! 🙇
src/main/java/org/sonarsource/sonarlint/ls/SonarLintExtendedLanguageClient.java
Show resolved
Hide resolved
sophio-japharidze-sonarsource
force-pushed
the
SLLS-345_fallBack_to_simple_error_for_some_clients
branch
4 times, most recently
from
6ebb716 to
920ef02
Compare
sophio-japharidze-sonarsource
force-pushed
the
SLLS-345_fallBack_to_simple_error_for_some_clients
branch
from
920ef02 to
3e152d4
Compare
|
sophio-japharidze-sonarsource
requested a review
from damien-urruty-sonarsource
2 participants
SLLS-345